Filterable widget posts rendering #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widget.zone-posts.php
Outdated
Member
There was a problem hiding this comment.
Cool idea. A better pattern I've found is to have false value passed to a filter and if unchanged, do the default render; something like:
$html = apply_filters( 'widget_zone_posts_override_html', false, $posts );
if ( $html !== false ) {
echo $html;
} else {
$this->widget_posts( $posts );
}
This way you're not echoing inside a filter which can be dangerous.
Author
|
Thanks, that definitely seems like a better way to do it. Updated. |
|
This would still be really great to see in this plugin. I came here thinking of doing a PR for this but it's already here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be handy to allow themes to override the rendering logic for a zone's widget. For example, a theme may want to include special CSS classes, or additional content such as thumbnail images or custom taxonomy. This is one way to implement this. Happy to try a different approach, etc.